Code Review - 30/08/2011

0

Category :

C#

check out asp.net "Skins" attaching CSS to controls
Themes - referenced images may be needed in multiple locations in project

ControlUtilities.GetDropDownValue(control);

validate user input on BOTH client and server

Log errors first and display after.

Try Catch Log and ShowError no need to throw

Parse csv of ints to pass to/from functions etc
---> Dev/CommonSQL/GeneralScripts

Web Service object: if 3 or more use a collection and not (Tutor1, Tutor2, Tutor3)

SQL

Check if columns exist when trying to Add new columns

Try Catch around ALL statements except stor procs

TRANS around ALL statements except stor procs

"Development\CommonSQL" for examples of code templates

Remove ALL square brackets [] from SQL scripts

No commentig out code just delete and let SVN handle

Add comments to SQL scripts

If updating a single stor proc use name in filename

Use stor procs to update date or retrieve multiple datasets
Use functions for rest usually just querying data

Try to ensure SQL patches run every evening!

Always Update database from scripts to ensure diagram and db stay in sync


SQL Server

When restoring database of dev server, activity monitor may need to be used to kill processes (from bottom up) related to database your trying to restore.


SQL Script naming convention

--------------------------------
000) structure updates
050) data updates
100) stor procs or function updates
500) reporting updates

0 comments:

Post a Comment